Ensure dummy metadata segment is json serializable.#403
Merged
Conversation
purple4reina
force-pushed
the
rey.abolofia/bug-context
branch
from
199783c to
dc18646
Compare
purple4reina
force-pushed
the
rey.abolofia/bug-context
branch
from
dc18646 to
d8c3447
Compare
Fixes error `TypeError: Object of type Context is not JSON serializable` #402
purple4reina
force-pushed
the
rey.abolofia/bug-context
branch
from
d8c3447 to
81720bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes error
TypeError: Object of type Context is not JSON serializable#402What does this PR do?
Fixes #402
When creating the xray metadata subsegment, we must pass a json serializable object. Unfortunately, a
ddtrace.context.Contextobject is not json serializable.Because the
create_dd_dummy_metadata_subsegmentmethod is used in other locations as well, we must convert theddtrace.context.Contextobject before calling this method.Motivation
Testing Guidelines
The test that I added passes with v82 of the layer but fails with v83 and v84. The fact that it again passes indicates to me that this fix will work.
Additional Notes
Types of Changes
Check all that apply